search

Cereal2nd / velbus-aio

Velbus Asyncio
Apache License 2.0
15 stars 10 forks source link

Bugfix vmbdali #115

Closed niobos closed 2 months ago

niobos commented 2 months ago

WARNING: WORK IN PROGRESS I haven't tested this on my installation yet

This should fix #114. It also adds a very basic test that should catch this in the future.

dverhelst commented 2 months ago

@niobos , can I be of assistance testing VMBDALI and VMBDALI-20 going forward?

niobos commented 2 months ago

I still need to test the changes on an actual installation that has the VMBDALI modules. Currently, I can't access it, but I should be able to in the next few weeks. If you know how to run Home Assistant with a development version of velbus-aio, you can try it and report back.

niobos commented 2 months ago

I can confirm that these changes fix the VMBDALI (1st version, not -20) in my installation.

What needs to happen next is that @Cereal2nd needs to release a new version of this library, and this new release needs to be referenced from the Home Assistant code. This is fairly straight-forward, but requires some manual work.

Cereal2nd commented 2 months ago

the pull-request has been created