Button presses are no longer registered

twalcari commented 2 years ago

Since the move to this library, button presses are no longer being registered.

Before the update, my logbook shows entries like these:

Those 'Push button' events are not there anymore this week.

Side note: I'm not entirely convinced that these binary_sensor's should be visible (enabled) in HA when a new Velbus installation is added. You typically have a lot of buttons, and only want to act on them in a very limited number of cases. We can easily disable them by default: https://developers.home-assistant.io/docs/entity_registry_disabled_by/#integrations-setting-default-value-of-disabled_by-for-new-entity-registry-entries . This way they stay available for users (if they enable them explicitly), but they stop cluttering the list of entities :-)

Cereal2nd commented 2 years ago

i see this: afbeelding

what type of modules is this?

twalcari commented 2 years ago

This is a VMB2PBN

On Thu, Oct 14, 2021 at 10:43 AM Maikel Punie @.***> wrote:

i see this: [image: afbeelding] https://user-images.githubusercontent.com/3715825/137282828-f6311c99-4a72-42ff-ab39-6000db6cdc81.png

what type of modules is this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Cereal2nd/velbus-aio/issues/15#issuecomment-943144275, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIJ3I5ADNMNC4UM5JILVHLUG2J2RANCNFSM5F7AWAZQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

Thijs Walcarius

Ghent University - imec IDLab iGent Tower - Department of Information Technology Technologiepark-Zwijnaarde 126, B-9052 Ghent, Belgium E: @. @.> W: IDLab.UGent.be http://idlab.ugent.be/ W: IDLab.technology http://idlab.technology/

Cereal2nd commented 2 years ago

this was introduced with the ayncio-protocol rewrite :) the problem is that not all messages are decoded, some messages are just ignored:


DEBUG:velbus-protocol:Received 10 bytes from Velbus: b'0f f8 4b 04 00 01 00 00 a9 04'
DEBUG:velbus-protocol:RX: RawMessage(priority=f8, address=4b, rtr=False, command=0, data=b'00 01 00 00')
DEBUG:velbus-protocol:Received 8 bytes from Velbus: b'0f fb 46 02 f5 02 b7 04'
DEBUG:root:Trimming leading garbage from buffer content: b'000000000ffb4602f502b7040000' becomes b'0ffb4602f502b7040000'
DEBUG:velbus-protocol:RX: RawMessage(priority=fb, address=46, rtr=False, command=245, data=b'f5 02')
DEBUG:velbus-packet:Received {"name": "ClearLedMessage", "priority": 251, "address": "46", "rtr": false, "leds_off": [2]}

only the second message is decoded the first one is never decoded, so the module.py never recieves this message

Cereal2nd / velbus-aio

Button presses are no longer registered #15