Improvements - Githubissues

Cereal2nd / velbus-aio

Velbus Asyncio

Apache License 2.0

15 stars 10 forks source link

Improvements #2

Closed brefra closed 3 years ago

brefra commented 3 years ago

Correctly link in coming channel updates to the correct channel if they belong to a submodule (address)
Correct format of counter status request message
Only do callback if value has changed
Do request a channel status request at startup if module/channel information is loaded from cache file.

Cereal2nd commented 3 years ago

let me know when you want to see this one merged

brefra commented 3 years ago

Yes it ready to merge. It runs okay a mine setup. The only issue I've noticed, using this module within a supervised hass enviroment, the cache files are stored within the core container. So you lose the cachefiles at every home assistant update. Not a breaking issue but it slows down the first start of a updated setup. I suggest to make the location configurable and have the Velbus Integration use the config folder of hass.