search

cereal2nd / velbus-aio

Velbus Asyncio
Apache License 2.0
15 stars 12 forks source link

Fix negative temperatures #28

Closed bdewitte123 closed 2 years ago

bdewitte123 commented 2 years ago

With outside temperatures going below 0 °C some weeks ago, I noticed my VMBPIRO reporting negative temperatures as 127°C. The proposed fix takes into account the sign-bit and adds the proper offset of -127.

Was already fixed in: https://github.com/thomasdelaet/python-velbus/pull/77/

Also fixes: https://github.com/home-assistant/core/issues/61238

cereal2nd commented 2 years ago

please run black and then update this PR, then all checks should pass and we can merge it

cereal2nd commented 2 years ago

thanks for this!