search

Cereal2nd / velbus-aio

Velbus Asyncio
Apache License 2.0
15 stars 10 forks source link

Python 3.10 incompatible #29

Closed frenck closed 2 years ago

frenck commented 2 years ago

Hi! 👋

I've been working on upgrading Home Assistant to Python 3.10, and noticed this package isn't compatible with Python 3.10.

Python upgrade PR: https://github.com/home-assistant/core/pull/59729

Error from tests:

  File "/__w/core/core/venv/lib/python3.10/site-packages/velbusaio/protocol.py", line 51, in __init__
  self._send_queue = asyncio.Queue(loop=self._loop)
  TypeError: As of 3.10, the *loop* parameter was removed from Queue() since it is no longer necessary

A quick sneak peek/search revealed more cases of passing the loop argument:

https://github.com/Cereal2nd/velbus-aio/search?q=loop

Could this be fixed? 🙏 ❤️

Thanks!

../Frenck

Cereal2nd commented 2 years ago

Started working on this https://github.com/Cereal2nd/velbus-aio/compare/py310