Cereal2nd / velbus-aio

Velbus Asyncio
Apache License 2.0
15 stars 10 forks source link

Move connect string to command line argument #45

Closed niobos closed 1 year ago

niobos commented 1 year ago

Hi,

I'm starting to look around in this repo to contribute. The first thing I noticed was these hard-coded connect string that kept popping up as "changes to be committed". So I decided to pull these out into command line argument for easier testing.

(And this is secretly also a test of how active this repo still is, and how hard it is to get things merged or get feedback on PRs)

Thanks, N

Cereal2nd commented 1 year ago

I like the idea

But you should first run all pre-commit checks, this will suggest a couple of changes to the files. Push these and then we can merge the pullrequest.

niobos commented 1 year ago

Applied requested changes, and I was impressed with your response time on this PR!!!