Support for VMBGP4PIR module, added support for thermostat and thermometer channels

Cereal2nd / velbus-aio

Velbus Asyncio

Apache License 2.0

14 stars 10 forks source link

Support for VMBGP4PIR module, added support for thermostat and thermometer channels #66

Closed DannyDeGaspari closed 1 year ago

DannyDeGaspari commented 1 year ago

Added module_status variant message for VMBGP4PIR module. Also added test for the module_status message.
Completed support for module program_selection (none, summer, winter, holiday) and thermostat operating_mode (run, manual, sleep, disable)
Thermostat channels were not updated if a TempSensorStatusMessage was received -> fixed (Heater, Boost, Pump, Cooler, Alarm1-4)

@Cereal2nd: The thermostat operating_mode and program_selection need modifications on HA side to make them work:

"Operating mode": stored in channel._cstatus variable and get from get: Channel Temperature.get_climate_mode() set: Channel Temperature.set_climate_mode(mode)
"Selected program": stored in the module itself in module.selected_program_str variable get: Module.get_selected_program() set: Module.get_selected_program(program_str)

DannyDeGaspari commented 1 year ago

Any idea why the python checks are failing ? Seems not to be related to the code itself.

Cereal2nd commented 1 year ago

Any idea why the python checks are failing ? Seems not to be related to the code itself.

i just fixed the the workflows, rebase and they should pass

DannyDeGaspari commented 1 year ago

Ok thanks. I'll take over @nielslaukens suggestion and test it first before I commit again. So hold on before you approve.

DannyDeGaspari commented 1 year ago

@Cereal2nd, @nielslaukens, Thanks for reviewing and guiding me to the correct implementation!

@Cereal2nd, you take care of the coupling of those 2 new features with HA ? Thanks.

Cereal2nd commented 1 year ago

@Cereal2nd, @nielslaukens, Thanks for reviewing and guiding me to the correct implementation!

@Cereal2nd, you take care of the coupling of those 2 new features with HA ? Thanks.

when i ahve some time to dot his i will couple it, not sure when, probably during the christmas period

Cereal2nd commented 1 year ago

when implementing the stuff in hass, i see the foloowing:

PROGRAM_SELECTION = {0: "none", 1: "summer", 2: "winter", 3: "holiday"}

is this correct, should this not be none, progam 1, program 2, ....

DannyDeGaspari commented 1 year ago

In theory, it can be anything. But I choose the names according to this table from Velbus: If you think it should be other names better inline with HASS, then feel free to change it.

Cereal2nd commented 1 year ago

The PR is open in homeaseistant to add the program selection

https://github.com/home-assistant/core/pull/87568

DannyDeGaspari commented 1 year ago

Thank you very much !!