search

CeresBarros / SpaDES4Dummies

A SpaDES crash-course with two tutorials
https://ceresbarros.github.io/SpaDES4Dummies/
1 stars 4 forks source link

gaussMap() is defunct; use NLMR::nlm_mpd() #15

Closed achubaty closed 1 year ago

achubaty commented 2 years ago

When I try to compile the spades4dummies locally, it generates an error, even if I have RandomFields installed, though.

Originally posted by @Kenkleinman in https://github.com/CeresBarros/SpaDES4Dummies/issues/13#issuecomment-1241053894

achubaty commented 2 years ago

@Kenkleinman

  1. what are you trying to compile? Are you trying to rebuild the bookdown book, or run a specific example?
  2. Can you please post the specific error(s) you are seeing, along with system information to help us diagnose the issue.
achubaty commented 2 years ago

@CeresBarros on my end, because we had to make defunct SpaDES.tool::gaussMap(), there are failures in several places:

image

In the randomLandscapes module I switched to using NLMR::nlm_mpd() in lieu of gaussMap().

E.g., see https://github.com/PredictiveEcology/SpaDES.core/blob/master/inst/sampleModules/randomLandscapes/randomLandscapes.R#L112-L120

achubaty commented 2 years ago

@CeresBarros branch 15-use-nlmr addresses the gaussMap() issue and also includes several other fixes for errors encountered during rebuilding.

  1. there may be a better NLMR function to use for the maps you are trying to simulate;
  2. I didn't spend any time tweaking the function call to approximate what gaussMap() was doing -- so the scale of the map vaules and 'chunkiness' of the landscape weren't really tweaked.
CeresBarros commented 2 years ago

Thanks @achubaty and @Kenkleinman for bringing up the issue. I'll have a look as soon as I can, but unlikely that'll be before next week

CeresBarros commented 1 year ago

fixed in current master branch