search

CermakM / argo-client-python

Python client for Argo Workflows | Mirrored to https://github.com/argoproj-labs/argo-client-python
https://github.com/argoproj/argo
Apache License 2.0
31 stars 8 forks source link

Support for CronWorkflow? #12

Closed bensternlieb closed 1 year ago

bensternlieb commented 4 years ago

Feature Request: Probably too early - but eager to use CronWorkflows! Great library!

CermakM commented 4 years ago

I'll do my best to generate new models ASAP :)

CermakM commented 4 years ago

Hey @bensternlieb ! I just generated new models in https://github.com/CermakM/argo-client-python/pull/14 for Argo v2.5.0-rc5. Not tested yet, but if you feel adventurous, you can take them for a spin :)

bensternlieb commented 4 years ago

Awesome! Will try it out. Thanks!

On Thu, Jan 30, 2020 at 9:25 AM Marek Čermák notifications@github.com wrote:

Hey @bensternlieb https://github.com/bensternlieb ! I just generated new models in #14 https://github.com/CermakM/argo-client-python/pull/14 for Argo v2.5.0-rc5. Not tested yet, but if you feel adventurous, you can take them for a spin :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CermakM/argo-client-python/issues/12?email_source=notifications&email_token=AD6NQVLI3FAQ5KZLYFSCFULRALPOBA5CNFSM4KGDLXZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKLFHXI#issuecomment-580277213, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD6NQVNH3CUTQTRKLNOYPTLRALPOBANCNFSM4KGDLXZA .

bensternlieb commented 4 years ago

Hey @CermakM - Just saw that Argo released v2.5. I checked out the branch:

git+git://github.com/CermakM/argo-client-python.git@argo/v2.5.0#egg=argo-workflows

but I think it might be missing some model artifacts. 

~/src/dl-workflow$ grep -i cron ~/.pyenv/versions/dl-workflows/lib/python3.8/site-packages/argo/workflows/client/models/__init__.py
from argo.workflows.client.models.v1alpha1_cron_workflow import V1alpha1CronWorkflow
from argo.workflows.client.models.v1alpha1_cron_workflow_list import V1alpha1CronWorkflowList
from argo.workflows.client.models.v1alpha1_cron_workflow_spec import V1alpha1CronWorkflowSpec
from argo.workflows.client.models.v1alpha1_cron_workflow_status import V1alpha1CronWorkflowStatus
~/src/dl-workflow$ ls ~/.pyenv/versions/dl-workflows/lib/python3.8/site-packages/argo/workflows/client/models/ | grep -i cron
~/src/dl-workflow$ ls ~/.pyenv/versions/dl-workflows/lib/python3.8/site-packages/argo/workflows/client/models/ | grep -i dag
v1alpha1_dag_task.py
v1alpha1_dag_template.py
CermakM commented 4 years ago

Hey @bensternlieb ... That's completely correct, I just noticed yesterday as well that I forgot to git add them :D I will fix that ASAP. Thanks for the heads-up!

Cheers, M

yxue-kabam commented 4 years ago

exciting! going to try out the latest release (great work)

brtasavpatel commented 4 years ago

hi guys, just wondering was the new models generated for v2.5.0?

CermakM commented 4 years ago

Hey @brtasavpatel, the models for v2.5.0 haven't been released yet, but you can test them out already at argo/v2.5.0 branch.