Cero-Studio / ReactNativeWheelPicker

Other
381 stars 240 forks source link

Status of this library/npm package/TypeScript definition #144

Open ca057 opened 3 years ago

ca057 commented 3 years ago

Hey! 👋

I was wondering about the status of this library and the related npm packages, currently there are two both pointing to this repo:

Do I assume correct that the latter one is the one we should use when using this library? But if I see it correctly in the node_modules, the latter version does not export TimePicker and DatePicker - are those two pickers removed? We should then update the documentation, as this can be confusing. In addition, it seems the TypeScript definitions are not picked up properly:

When I import the WheelPicker as following:

import { WheelPicker } from '@victorzimnikov/react-native-wheel-picker-android';

I receive an error from TypeScript stating Module '"node_modules/@victorzimnikov/react-native-wheel-picker-android"' has no exported member 'WheelPicker'. I assume this is the case as the export in index.js (export * from "./src/WheelPicker";) relies on the platform specific distinction performed by React Native which TypeScript won’t do. Is there any work already going on to fix those definitions or is this something where I can jump in?

Thanks!

EDIT: I have the feeling the other library I found on npm is not the right one we should use, but a temporary hack to have a newer version? Is it possible to publish an update of this npm package (react-native-wheel-picker-android) to npm, so we benefit e.g. from the switch to the picker of react-native-community?

torufuruya commented 3 years ago

Can we have any updates on this topic?