CertifaiAI / classifai

:fire: One of the most comprehensive open-source data annotation platform.

https://classifai.ai/

Apache License 2.0

119 stars 25 forks source link

♻️ Remove JsonObject from return value #505

Closed devenyantis closed 3 years ago

devenyantis commented 3 years ago

Description

Some return values are changed. Some remain as json object. Also added steps to handle fail cases to map the functionality of frontend.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

[ ] Bug fix (Non-breaking change which fixes an issue)
[ ] New feature (Non-breaking change which adds functionality)
[x] Breaking change (Fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update (Example: REST API changes)

Tested on?

[x] Windows
[ ] Linux Ubuntu
[ ] Centos
[ ] Mac
[ ] Others (State here -> xxx )

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged
[ ] CHANGELOG.md has been updated
[ ] Update Gitbook REST API Page

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication