search

CesiumGS / 3d-tiles-tools

Apache License 2.0
307 stars 45 forks source link

Stop writing temporary tilesets to the specs folder during the tests #11

Closed lilleyse closed 1 year ago

lilleyse commented 7 years ago

If possible, use writeCallback or at least use OS temp directories.

javagl commented 2 years ago

Assuming that this refers to things like https://github.com/CesiumGS/3d-tiles-tools/blob/645d86631442adaa5b79471e2153bbdfa50893cf/specs/lib/combineTilesetSpec.js#L156 , I'll move this from the validator to the tools repository.

javagl commented 1 year ago

With the new functionality of 0.2.0, it will be hard to avoid writing "any" files.

Part of the 0.2.0 functionality is to convert between (file,ZIP,3TZ,3DTILES) and (file,3TZ,3DTILES). Testing this functionality requires a file system. In a few places, there already is something like

  afterEach(function () {
    SpecHelpers.forceDeleteDirectory(basicOutput);
  });

to clean things up. This is not yet done for all written files, but could certainly be extended, if the goal was to work towards a state where the specs leave the directories "'clean', as if they had never been run".

So I don't think this is critical, but will leave it open for now...

javagl commented 1 year ago

The current specs do ("inherently") write data to the specs/data/output folder, but as of now, all the output should be cleaned up after the tests, so I think that it is OK to close this one.