CesiumGS / 3d-tiles-validator

Validator for 3D Tiles :vertical_traffic_light:
https://cesium.com
Apache License 2.0
427 stars 156 forks source link

Handle missing 'refine' in root #303

Closed javagl closed 9 months ago

javagl commented 9 months ago

(Builds upon https://github.com/CesiumGS/3d-tiles-validator/pull/302 , to be merged first)

Fixes https://github.com/CesiumGS/3d-tiles-validator/issues/301

A missing 'refine' in a root tile was not detected by the validator until now. With this PR, it causes an TILE_REFINE_MISSING_IN_ROOT error to be issued.

NOTE: The actual fix was pretty simple, and only consists of the small code block at https://github.com/CesiumGS/3d-tiles-validator/commit/a76420ac1b36f2a8355c1e022369674645c9e995#diff-16f3605f538db4f2045f8481ccc3ed655a2c44eb2c4d066f19e102065719eaacR186

The large number of changed files here stems from the fact that all the /spec tileset JSON files did generally not define the refine property in the root. So they have been updated to include it as necessary.