search

CesiumGS / 3d-tiles

Specification for streaming massive heterogeneous 3D geospatial datasets :earth_americas:
2.11k stars 467 forks source link

Remove `group.id` property #678

Closed lilleyse closed 2 years ago

lilleyse commented 2 years ago

Removes the group.id property so the groups are consistent with other metadata entities. Metadata entities such as tilesets, tiles, contents, and groups should use the ID semantic.

There was some discussion about this in https://github.com/CesiumGS/3d-tiles/pull/648#pullrequestreview-900412973.

lilleyse commented 2 years ago

Now becoming more relevant: https://github.com/CesiumGS/cesium/issues/10223

Yes, thanks for the reminder. @j9liu could you look at that?

lilleyse commented 2 years ago

(Also, I'll have to update the samples that needed ID to circumvent this issue)

Does that just include https://github.com/CesiumGS/3d-tiles-samples/tree/main/1.1/MetadataGranularities?

javagl commented 2 years ago

Does that just include https://github.com/CesiumGS/3d-tiles-samples/tree/main/1.1/MetadataGranularities?

Yes, this seemed to be the only model that defined groups for now. The PR is at https://github.com/CesiumGS/3d-tiles-samples/pull/46