search

CesiumGS / 3d-tiles

Specification for streaming massive heterogeneous 3D geospatial datasets :earth_americas:
2.14k stars 469 forks source link

Fix wording in description for tile children #753

Closed javagl closed 1 year ago

javagl commented 1 year ago

Fixes https://github.com/CesiumGS/3d-tiles/issues/752

OLD: "For leaf tiles, the length of this array is zero, and children may not be defined" NEW: "For leaf tiles, there are no children, and this property may not be defined"

lilleyse commented 1 year ago

There are a few other occurrences of "length of this array is zero" that need to be fixed

image

javagl commented 1 year ago

These are the parts that are auto-generated from the schema. I wasn't sure whether this should be part of this PR, but I can update them as well.

javagl commented 1 year ago

The auto-generated files apparently had not been updated for a while, e.g. after https://github.com/CesiumGS/3d-tiles/commit/c32e4cf25dc094c555e78429eec82ff6d387101e - so it's probably good to have them on the latest state here again.

javagl commented 1 year ago

While looking at the diff of the generated output, I noticed that there was a wrong description for the properties.minimum/maximum properties. I hope it's OK to sneak that fix in here...