search

CesiumGS / cdb-to-3dtiles

Convert CDB to 3D Tiles
Apache License 2.0
76 stars 28 forks source link

CDB to 3D Tiles should stable OpenSceneGraph version #11

Closed baothientran closed 3 years ago

baothientran commented 3 years ago

Currently the converter are using the OSG in their master branch. However, we should test it with stable branch to see if there are any regression error. @mramato tried to build the converter but encountered the error:

In file included from /var/app/CDBTo3DTiles/src/CDB.h:5,
                 from /var/app/CDBTo3DTiles/src/CDBTileset.cpp:2:
/var/app/CDBTo3DTiles/src/CDBModels.h:124:10: error: ‘void CDBTo3DTiles::CDBModel3DResult::apply(osg::Geometry&)’ marked ‘override’, but does not override
     void apply(osg::Geometry &geometry) override;
          ^~~~~
baothientran commented 3 years ago

it seems like v3.2 OSG doesn't have the apply(Gemeotry &) The minimum version is 3.4 does support it. I'm currently building it to test at the moment and update CMake accordingly

lilleyse commented 3 years ago

The code is now using the OpenSceneGraph 3.6.4 release