Tinygltf add unsupported wrapR in the gltf sampler

CesiumGS / cdb-to-3dtiles

Convert CDB to 3D Tiles

Apache License 2.0

76 stars 28 forks source link

Tinygltf add unsupported wrapR in the gltf sampler #20

Open baothientran opened 3 years ago

baothientran commented 3 years ago

Tinygltf currently adds wrapR to the json. Do we have any way to remove it?

nithinp7 commented 3 years ago

I added a comment to an existing issue in the tinygltf repository concerning wrapR. This doesn't look like something we can change on our end without having to directly modify the outputted glb.

https://github.com/CesiumGS/cdb-to-3dtiles/blob/0ec2f8b504fb6944d0940de5a8cf1276d30f453e/CDBTo3DTiles/src/TileFormatIO.cpp#L187-L189

nithinp7 commented 3 years ago

Good news, the owner of the tinygltf repository removed wrapR from tinygltf after I bumped this issue earlier today. He had initially included wrapR with hopes that gltf would eventually support 3d textures.

So the next step on our end will be to switch to the current version of tinygltf.