search

CesiumGS / cdb-to-3dtiles

Convert CDB to 3D Tiles
Apache License 2.0
76 stars 28 forks source link

Check if terrain simplified mesh is empty #25

Closed baothientran closed 3 years ago

baothientran commented 3 years ago

Sometime, when the decimation is more aggressive, the simplified mesh will be empty. If it is, we will use uniform grid mesh instead. That should not happen too often and only when uniform grid mesh is too small

lilleyse commented 3 years ago

Make sure to update CHANGES.md after https://github.com/CesiumGS/cdb-to-3dtiles/pull/23 is merged.

lilleyse commented 3 years ago

Is it possible to add a unit test for this?

baothientran commented 3 years ago

@lilleyse I updated the test in the new commit

lilleyse commented 3 years ago

Thanks @baothientran. While the test ended up being way more work than the fix itself I think it'll be a good safeguard for both for this edge case and the uniform grid mesh in general.

lilleyse commented 3 years ago

Also, please update CHANGES.md, then we can get this merged.

baothientran commented 3 years ago

@lilleyse updated

lilleyse commented 3 years ago

Thanks Bao!