search

CesiumGS / cesium-concierge

I automate common GitHub tasks
Apache License 2.0
6 stars 4 forks source link

Is "Cesium" hard coded? #53

Closed pjcozzi closed 7 years ago

pjcozzi commented 7 years ago

For example, in this repo:

I am a bot who helps you make Cesium awesome! Thanks again.

https://github.com/AnalyticalGraphicsInc/cesium-concierge/pull/52#issuecomment-320766906

Can it be a variable?

ottaviohartman commented 7 years ago

It is, currently.

Were you thinking a variable in the code? Or an environment-specific config variable?

pjcozzi commented 7 years ago

This has a config JSON where I set all my project-specific settings, right? I would expect this to be there so I can tweak everything in one place.

ottaviohartman commented 7 years ago

Gotcha

mramato commented 7 years ago

@omh1280 as previously discussed in the initial pull request, each repository should have a signature option that can be modified for each repository, so not just a name, but the entire last line.

ottaviohartman commented 7 years ago

What about hard-coded links like to the pull request guidelines? Right now it's split into multiple messages.

Should each be configurable?

ottaviohartman commented 7 years ago

Or maybe one signature if Third-party files change, and one if CHANGES.md does

mramato commented 7 years ago

What about hard-coded links like to the pull request guidelines? Right now it's split into multiple messages.

Should each be configurable?

Ultimately, we are going to have to allow for as much configuration as needed to get the job done. This can be tricky with generated content because you essentially need some sort of templating system to do it right (which is why I haven't worried about it yet). Let's get the stale PR bumper and CLA stuff done first before we worry about this.

ottaviohartman commented 7 years ago

I was thinking the same.

If there is a good templating library you use, I'd be happy using it in a pinch. It would definitely make the code cleaner.

mramato commented 7 years ago

handlebars is what we have used in the past, and I see no reason why that wouldn't work here.