CesiumGS / cesium-omniverse

Bringing the 3D geospatial ecosystem to Omniverse
https://cesium.com/platform/cesium-for-omniverse/
Apache License 2.0
55 stars 7 forks source link

Cartographic Polygon and Polygon Imagery layer default values #631

Closed r-veenstra closed 7 months ago

r-veenstra commented 7 months ago

I suggest we implement the following default values to make using cartographic polygons and polygon overlays a little easier

Imagery Overlay

Cartographic Polygons - defaults when creating by any method

cc @corybarr

corybarr commented 7 months ago

Setting point3f[] points = [(-1000, 0, -1000), (-1000, 0, 1000), (1000, 0, 1000), (1000, 0, -1000)] in the USD schema leads to a crash in Omniverse when a CesiumCartographicPolygonPrim is created. I'm seeing if this is solvable, but it might have to be done at the Python level during prim creation.

lilleyse commented 7 months ago

@corybarr does that crash happen in https://github.com/CesiumGS/cesium-omniverse/pull/626?

corybarr commented 7 months ago
  • point3f[] points = [(-1000, 0, -1000), (-1000, 0, 1000), (1000, 0, 1000), (1000, 0, -1000)] - Helpful to have some pre-existing points for the user to grab and edit, vs trying to draw from scratch. Unreal does this. (especially as raycasting to tilesets is not currently available)

    Create an issue with the title point3f[] points = [(-1000, 0, -1000), (-1000, 0, 1000), (1000, 0, 1000), (1000, 0, -1000)] - Helpful to have some pre-existing points for the user to grab and edit, vs trying to draw from scratch. Unreal does this. (especially as raycasting to tilesets is not currently available). Press Enter to convert to an issue instantly. Press Alt-Enter to open the create new issue form in the current tab. Press Shift-Enter to open the create new issue form.

  • [x] uniform token type = "linear" - Helpful to avoid accidental use of curves which aren't supported

    Create an issue with the title uniform token type = "linear" - Helpful to avoid accidental use of curves which aren't supported. Press Enter to convert to an issue instantly. Press Alt-Enter to open the create new issue form in the current tab. Press Shift-Enter to open the create new issue form.

  • [x] uniform token wrap = "periodic" - Ensures the polygon is closed

@lilleyse It does happen in #626. The crash's trace doesn't go through our code.

corybarr commented 7 months ago

Setting point3f[] points = [(-1000, 0, -1000), (-1000, 0, 1000), (1000, 0, 1000), (1000, 0, -1000)] in the USD schema leads to a crash in Omniverse when a CesiumCartographicPolygonPrim is created. I'm seeing if this is solvable, but it might have to be done at the Python level during prim creation.

Since some attributes require setting other attributes, I tried adding curveVertexCounts and extent. I still got the crash. Given that, I copied all attributes from a working CesiumCartographicPolygonPrim but still get the instantiation-time crash.