Only print warnings for properties that are in use

CesiumGS / cesium-omniverse

Bringing the 3D geospatial ecosystem to Omniverse

https://cesium.com/platform/cesium-for-omniverse/

Apache License 2.0

55 stars 7 forks source link

Only print warnings for properties that are in use #655

Closed lilleyse closed 7 months ago

lilleyse commented 7 months ago

Fixes https://github.com/CesiumGS/cesium-omniverse/issues/588

https://github.com/CesiumGS/cesium-omniverse/commit/d02944fd13be9d8633ae97733770c047b343c91a - cleanup commit so that oneTimeWarning can take multiple arguments
https://github.com/CesiumGS/cesium-omniverse/commit/c5c68dc412801532b789b16efd9f4f7991a050a6 - use oneTimeWarning for "Could not find property" and "incompatible type" warnings

lilleyse commented 7 months ago

I'm working on a more complete fix for https://github.com/CesiumGS/cesium-omniverse/issues/588, marked as draft in the meantime.

lilleyse commented 7 months ago

Updated so that warnings are only printed for properties that are in use.

This required storing property warnings in FabricMaterialDescriptor so that they could be accessed by FabricMaterial later. There were also some changes in MetadataUtil to make unsupported property handling more generic through callbacks.

lilleyse commented 7 months ago

Looking into a performance degradation with the new change