CesiumGS / cesium-omniverse

Bringing the 3D geospatial ecosystem to Omniverse
https://cesium.com/platform/cesium-for-omniverse/
Apache License 2.0
51 stars 7 forks source link

Wait for loading tiles when using the movie capture tool #674

Closed lilleyse closed 5 months ago

lilleyse commented 5 months ago

Fixes https://github.com/CesiumGS/cesium-omniverse/issues/198.

I confirmed that updateViewOffline is called when the movie capture tool is active, and updateView is called otherwise, but I haven't been able to verify the results because I'm having trouble with the Capturing Images and Video tutorial. Marking as draft until that's resolved.

r-veenstra commented 5 months ago

Looks good. Both these are with settle latency at 0

0.17.0:

https://github.com/CesiumGS/cesium-omniverse/assets/123468416/01fccd05-b5c6-43ec-a304-4e8db3ef3dd7

This branch:

https://github.com/CesiumGS/cesium-omniverse/assets/123468416/7e8997e9-f17d-4c79-9b0d-ebe90996b0e8

Captures are much faster than when using an arbitary value for settle latency too!

lilleyse commented 5 months ago

Great, I'll mark this as ready for review then

corybarr commented 5 months ago

Is the changing geometry in the render from this branch due to geometric error?

lilleyse commented 5 months ago

Is the changing geometry in the render from this branch due to geometric error?

I believe so