search

CesiumGS / cesium-unity

Bringing the 3D geospatial ecosystem to Unity
https://cesium.com/platform/cesium-for-unity/
Apache License 2.0
358 stars 83 forks source link

Handle incomplete mip chains correctly #347

Closed kring closed 1 year ago

kring commented 1 year ago

Depends on CesiumGS/cesium-native#682 so merge that first Fixes #346

When cesium-native provided a mipPositions array with fewer than the total number of mip levels that could be present, the remaining ones were left uninitialized. With this PR, whatever mip levels are provided are used.

kring commented 1 year ago

Draft because it needs more testing and also we really should implement the cesium-native change described here: https://github.com/CesiumGS/cesium-unity/issues/274#issuecomment-1523834437

It works well for the tileset described in #346, though.

kring commented 1 year ago

This is ready for review now.

j9liu commented 1 year ago

@kring looks great, thanks!