Closed azrogers closed 6 months ago
Looks great! Please just merge in main. It's another painful conflict, unfortunately.
@kring Merged with main! It feels a little bit like I did something wrong in the merge but the changes look right to me, so 🤷♀️
The changes look good, except that it looks like there's an accidental cesium-native downgrade in here. It's really easy to do, because submodules don't merge quite the same way that normal files do. If you just do the normal process of 1) git merge origin/main
, 2) fix conflicts, 3) git commit -a
, you'll end up accidentally reverting submodules changes in the branch you're merging from. The trick is to do 2.5) git submodule update --init --recursive
Thanks @azrogers !
Fixes #332.
Currently, all textures in Unity are loaded as if they're sRGB textures. This isn't correct for things like normal maps, where treating them as sRGB will mess up the direction of the normals. This change adds a flag to
TextureLoader::loadTexture
to allow specifying which textures are sRGB, and specifies the flag for each texture loaded based on the Unreal implementation.