search

CesiumGS / cesium-unity

Bringing the 3D geospatial ecosystem to Unity
https://cesium.com/platform/cesium-for-unity/
Apache License 2.0
347 stars 83 forks source link

Ability to update Tileset options without reloading tileset #412

Open whitebozo opened 7 months ago

whitebozo commented 7 months ago

Added the ability to update tileset options without the need to reload full tileset.

kring commented 7 months ago

Thanks for the PR @whitebozo! Can I bug you to sign our Contributor License Agreement so that we can review this? https://github.com/CesiumGS/cesium/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla

whitebozo commented 7 months ago

Thanks for the PR @whitebozo! Can I bug you to sign our Contributor License Agreement so that we can review this? https://github.com/CesiumGS/cesium/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla

No problem I sent over the details to my boss waiting for him to fill it out on behalf of our company.

I will reply in here once we have signed the CLA.

j9liu commented 6 months ago

Hi @whitebozo, did you end up signing a CLA? Let us know if this is ready for a review, we'll be able to take a look!

whitebozo commented 6 months ago

Hi @whitebozo, did you end up signing a CLA? Let us know if this is ready for a review, we'll be able to take a look!

Still waiting for upper management to sign the CLA on behalf of our company. Sorry for the delay.

electrum-bowie commented 2 months ago

@kring

How LONG does it take you guys to pull this absolutely essential feature ??

I've been waiting for MONTHS thinking it will be added in the next version.....

EVERY Project that allows some kind of LOD / Performance option is absolutely ruined by the outrageous "reload" effect, EVERY. SINGLE. TIME..

It COMPLETELY breaks the entire game / app experience, and MOST apps / games with Cesium needs some kind of Level of Detail slider ...

Funny how nobody cares assuming it isn't possible to implement when EVERYTHING is already developed and completely implemented ready to solve this monstruos problem but instead it's sitting here for months ignored.

whitebozo commented 2 months ago

@kring

How LONG does it take you guys to pull this absolutely essential feature ??

I've been waiting for MONTHS thinking it will be added in the next version.....

EVERY Project that allows some kind of LOD / Performance option is absolutely ruined by the outrageous "reload" effect, EVERY. SINGLE. TIME..

It COMPLETELY breaks the entire game / app experience, and MOST apps / games with Cesium needs some kind of Level of Detail slider ...

Funny how nobody cares assuming it isn't possible to implement when EVERYTHING is already developed and completely implemented ready to solve this monstruos problem but instead it's sitting here for months ignored.

This is not the cesium team’s fault on the time it has taken for this feature to be pulled in my CEO never sent over a signed CLA so they can’t really pull this in without that. Feel free to take my PR and make another PR with a signed CLA. Until then or until my company signs the CLA the cesium team’s hands are tied. I’m sorry about the delay. The feature does work and we have been using internally at my company.

In hindsight I should have made this feature myself outside of my company’s umbrella and signed the CLA as an individual but since this PR is coming from my company’s GitHub account I had to go through the proper bureaucracy of getting the company to sign the CLA.

kring commented 2 months ago

Thanks for opening this PR @whitebozo, and for continuing to push your management to bless the community's use of it. One thing that may help to persuade them is to point out that these changes likely have very little commercial value for you, and yet you're stuck re-integrating them into each new release. So it's actually to your company's benefit to sign the CLA and allow these changes to be merged, because it will save you work. It's not just a gift to the community.

Unfortunately, if someone else were to copy these changes and open a separate PR, we still wouldn't be able to merge it. The CLA requires that the contributor have the legal right to contribute the changes, and they wouldn't in this case because your company hasn't granted it. Someone else could re-implement this feature themselves, of course (including us at Cesium).

@electrum-bowie I understand your frustration, but please try to tone it down a little. Keep in mind that you always have the option of making your own changes to Cesium for Unity - or hiring someone to do so - when the product as-is isn't quite meeting your needs.

raggnic commented 1 month ago

Still waiting for upper management to sign the CLA on behalf of our company. Sorry for the delay.

I had the same issue. Management guys are very cautious in big companies