search

CesiumGS / cesium-unity

Bringing the 3D geospatial ecosystem to Unity
https://cesium.com/platform/cesium-for-unity/
Apache License 2.0
347 stars 83 forks source link

add WebMapTileServiceRaster support (WMTS) #430

Closed tal952 closed 6 months ago

tal952 commented 6 months ago

Added WMTS support. Based it on the WMS current support.

tal952 commented 6 months ago

Hello @j9liu , Given that this Pull Request builds upon your prior contributions to the WMS support, could you kindly take a moment to review it? Your insights would be greatly appreciated.

kring commented 6 months ago

Thanks for the PR @tal952!

Can I bug you to please sign the Contributor License Agreement so that we can review this? https://github.com/CesiumGS/cesium/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla

Thanks!

tal952 commented 6 months ago

Hey @kring , signed the Contributor License Agreement 👍

tal952 commented 6 months ago

Hey @kring and @j9liu , any chance you can help me with review? 🙏 Please let me know if I can help somehow

kring commented 6 months ago

Really appreciate the PR @tal952, and we'll review this as soon as we can. It might be a little bit though, we have a long review backlog at the moment.

j9liu commented 6 months ago

@tal952 thanks for the responses to my comments above. Let me know when I should take another look!

tal952 commented 6 months ago

Hey @j9liu , looks like I fixed everything you mentioned, if you can take another look it would be awesome 🙏🙏

j9liu commented 6 months ago

Looks good to me @tal952, thanks for the contribution! I'll do a follow-up PR to add those extra settings to the overlay, just for parity with Unreal.