search

CesiumGS / cesium-unity

Bringing the 3D geospatial ecosystem to Unity
https://cesium.com/platform/cesium-for-unity/
Apache License 2.0
358 stars 83 forks source link

Fix CI formatting issues (clang-format 18) #438

Closed j9liu closed 8 months ago

j9liu commented 8 months ago

This PR fixes the CI formatting errors currently on main.

CI has started using clang-format v18, which is unhappy about the JustBeforeDelete function defined in the .h files. Although I could have installed and ran clang-format v18, I realized that this function wasn't even necessary for the classes it was defined in. I have hence removed the function from those files.

I also moved the other empty function definitions to the .cpp files, to keep stylistically consistent with other classes in the plugin.

csciguy8 commented 8 months ago

Looks good @j9liu ! Thanks for the fix.