search

CesiumGS / cesium-unity

Bringing the 3D geospatial ecosystem to Unity
https://cesium.com/platform/cesium-for-unity/
Apache License 2.0
347 stars 83 forks source link

Fix changing CesiumGlobeAnchor position while disabled #480

Closed azrogers closed 2 months ago

azrogers commented 2 months ago

As noted in #476, the ellipsoid changes added a reference to _georeference in the longitudeLatitudeHeight property on CesiumGlobeAnchor. This is fine for most purposes, as _georeference will be set by the time longitudeLatitudeHeight is used - unless the CesiumGlobeAnchor is disabled. This change just makes sure the georeference has been found before trying to access it.

kring commented 2 months ago

Looks good other than that one thing. Please remember to update CHANGES.md, too.

j9liu commented 2 months ago

@kring Ashley probably won't be able to get back to this before the release (since she's out).

Would it be okay if you or @csciguy8 want to implement the feedback + merge this to main? (I will also be out, but can try to support if needed)

kring commented 2 months ago

Yeah good call @j9liu. I'll make that small change and merge it.

electrum-bowie commented 2 months ago

???

electrum-bowie commented 2 months ago

@kring when will i be able to update the cesium unity package to receive this fix ?

kring commented 2 months ago

We're planning to release it tomorrow. You can grab a build from CI in the meantime if you like.

electrum-bowie commented 2 months ago

CI ?

kring commented 2 months ago

Continuous Integration. The plugin is built on GitHub Actions on every commit. If you're not familiar, better to just wait for the release.