CesiumGS / cesium-unreal-vr-tutorial

Unreal Engine project, assets, and code used in the Cesium for Unreal VR Tutorial Series
Apache License 2.0
34 stars 6 forks source link

Vignettes #31

Closed CesiumBen closed 2 years ago

CesiumBen commented 2 years ago

Summary

This PR covers the technical aspects of vignettes.

Author checklist

Testing plan

Test the main level and the vignette level, movements, snap rotation and teleportation should cause the vignette to activate. While both levels are identical at this point. The main level pawn will continue to grow with features while the vignette pawn in the vignette level is locked as such going forward, simply to isolate movement functionality and vignettes.

Reminders for reviewers

Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author. Please keep these points in mind throughout the review process:

xuelongmu commented 2 years ago

Did video call code review with Ben. Remaining items:

OK to self merge after these are addressed.

CesiumBen commented 2 years ago

Test that the new map range function - Is working as expected Test new decay time implementation - Works and can clearly see the vignette fading. Move min/max radius params into material - I've adjusted that and works well Check whether blink should be used when snap rotating. - Blink should be used when rotating

Thanks @xuelongmu! All has been updated and I'm merging.