Closed csciguy8 closed 10 months ago
Thanks for the pull request @csciguy8!
Reviewers, don't forget to make sure that:
Not really sure this is a good candidate for a merge, quite yet.
Latest CI times for a successful packaging job takes from 52-148 mins. This is up from 19-24 mins.
Closing this PR for now.
My last comment suggests we shouldn't merge this due to the increased CI time, and I still think this.
It could be that a proper solution does what this PR does, but additionally solves some of the CI time issues.
Closes #1266
CI packaging tests now detect errors in
Engine.ini
, as demonstrated in this run.The tradeoff is now we run with
-cook
instead-cookonthefly
, which makes the packaging tests run much slower than before. It's probably fair to test cooking our plugin assets, but this does make our slow CI builds even slower.Here is another run that shows packaging tests times before these changes (19-24 mins), here