Fix packaging tests not failing, when they should

CesiumGS / cesium-unreal

Bringing the 3D geospatial ecosystem to Unreal Engine

https://cesium.com/platform/cesium-for-unreal/

Apache License 2.0

938 stars 295 forks source link

Fix packaging tests not failing, when they should #1286

Closed csciguy8 closed 10 months ago

csciguy8 commented 12 months ago

Closes #1266

CI packaging tests now detect errors in Engine.ini, as demonstrated in this run.

The tradeoff is now we run with -cook instead -cookonthefly, which makes the packaging tests run much slower than before. It's probably fair to test cooking our plugin assets, but this does make our slow CI builds even slower.

Here is another run that shows packaging tests times before these changes (19-24 mins), here

cesium-concierge commented 12 months ago

Thanks for the pull request @csciguy8!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium for Unreal Samples works.

csciguy8 commented 11 months ago

Not really sure this is a good candidate for a merge, quite yet.

Latest CI times for a successful packaging job takes from 52-148 mins. This is up from 19-24 mins.

csciguy8 commented 10 months ago

Closing this PR for now.

My last comment suggests we shouldn't merge this due to the increased CI time, and I still think this.

It could be that a proper solution does what this PR does, but additionally solves some of the CI time issues.