DitherFade material layer breaks glTF alphaMask rendering #1311

CesiumGS / cesium-unreal

Bringing the 3D geospatial ecosystem to Unreal Engine

https://cesium.com/platform/cesium-for-unreal/

Apache License 2.0

916 stars 292 forks source link

DitherFade material layer breaks glTF alphaMask rendering #1311 #1324

Closed stephLVCim closed 8 months ago

stephLVCim commented 8 months ago

Changed MLB_DitherFade like this :

So that the gltf objects with a "MASK" blending mode are correctly displayed, after a discussion with @kring .

Fixes #1311

kring commented 8 months ago

Thanks for the PR @stephLVCim! I don't think we have a Contributor License Agreemnt (CLA) from you yet. Details here: https://github.com/CesiumGS/cesium/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla

kring commented 8 months ago

Thanks for signing the CLA @stephLVCim. I've pushed your changes to https://github.com/CesiumGS/cesium-unreal/tree/alpha-mask (that link will stop working once the branch is merged and deleted). I've also replaced the "Min" function with "Multiply", which I think is more correct, and updated CHANGES.md. If CI is happy, I'll merge this. Thanks again for the PR!

kring commented 8 months ago

Merged! Thanks @stephLVCim.