Remove unnecessary parameters from glTF normals methods.

CesiumGS / cesium-unreal

Bringing the 3D geospatial ecosystem to Unreal Engine

https://cesium.com/platform/cesium-for-unreal/

Apache License 2.0

902 stars 287 forks source link

Remove unnecessary parameters from glTF normals methods. #1338

Closed azrogers closed 7 months ago

azrogers commented 7 months ago

Fixes #1290.

As pointed out in the issue, this doesn't actually constitute a bug as these methods will only be called when indices and vertices are the same length. However, it's a bit confusing and the indices parameter is unnecessary regardless. This change removes the parameter from both methods and changes the loops to use the length of the vertices array instead.

j9liu commented 7 months ago

Looks great @azrogers ! Happy to merge once CI passes.

j9liu commented 7 months ago

Merging now. Congrats on your first PR @azrogers !