CesiumGS / cesium-unreal

Bringing the 3D geospatial ecosystem to Unreal Engine
https://cesium.com/platform/cesium-for-unreal/
Apache License 2.0
902 stars 287 forks source link

New metadata unit test failures caused by texture wrapping modes #1342

Closed kring closed 6 months ago

kring commented 6 months ago

There are a number of Cesium for Unreal test failures when we upgrade to the latest version of cesium-native. I think the cause is CesiumGS/cesium-native#793.

In the one I looked at in detail (Unit -> FeatureIdSet -> GetFeatureIDFromHit -> returns correct value for texture set), the problem is that the default wrapping mode is REPEAT, and the test doesn't change that. And as a result, now that we're honoring the wrap mode, the texture coordinates (1,0) get wrapped to (0,0). Arguably, wrapping a value that is not actually outside the 0-1 range is wrong? But using the REPEAT mode in this test is also wrong, I'd say. So I'm not sure if this is a bug in the test or the production code (or both).