CesiumGS / cesium-unreal

Bringing the 3D geospatial ecosystem to Unreal Engine
https://cesium.com/platform/cesium-for-unreal/
Apache License 2.0
902 stars 287 forks source link

Support `KHR_texture_transform` for feature ID textures #1360

Closed j9liu closed 5 months ago

j9liu commented 6 months ago

Depends on #1355 (which I still have to get working, sorry :sob:)

This adds support for KHR_texture_transform for feature ID textures, both with picking and styling. To make sure this actually worked, I used the sample model that CesiumJS uses for its specs: https://github.com/CesiumGS/cesium/tree/main/Specs/Data/Models/glTF-2.0/FeatureIdTextureWithTextureTransform/glTF.

HOWEVER, be sure to modify the glTF so that the feature ID set has "featureCount": 64,. This is required by the spec, so it's an error on the model's part.

To test picking:

To test styling:

Bonus Changes:

kring commented 5 months ago

Thanks @j9liu!

javagl commented 5 months ago

@j9liu

HOWEVER, be sure to modify the glTF so that the feature ID set has "featureCount": 64,. This is required by the spec, so it's an error on the model's part.

Just drop me a note when you notice something like this - I added this file without validating, so that's my fault.

Fix is in https://github.com/CesiumGS/cesium/pull/11863

j9liu commented 5 months ago

Thanks for noticing @javagl -- I intended to create a fix, but got completely distracted. 😓