Closed j9liu closed 5 months ago
@j9liu when you've addressed the minor comments here and in https://github.com/CesiumGS/cesium-native/pull/822, please go ahead and merge them yourself. That way I won't need to wait for CI before I can start the release process at the end of your day today.
Thanks @kring for the review! Merging with your approval.
Depends on https://github.com/CesiumGS/cesium-native/pull/822, so merge that first.
Similar to #1360 . Use https://github.com/CesiumGS/cesium/tree/main/Specs/Data/Models/glTF-2.0/PropertyTextureWithTextureTransform/glTF for this one.
Picking
Styling
KHR_texture_transform
:Bonus Changes
1330 unfortunately made things complicated for the sample models used, because the base color texture and the features / metadata texture used are the same. I feel like this isn't a robust fix, but what I've done as a band-aid for the release:
FCesiumModelMetadata
is created, iterate over all of the primitive's materials, and find if any of the images are used by metadata. If so, we insert amakeImageCopy = true
variable in theextras
.FCesiumPrimitiveFeatures
is created (and before material textures are loaded), do the same thing as above.TextureView
will be created with a CPU copy, which avoids picking errors.@kring I know you suggested the approach of duplicating textures in the glTF itself, but I'm hesitant to modify the glTF images itself? (maybe unjustifiably so). But let me know if what I've done is atrocious.