CesiumGS / cesium-unreal

Bringing the 3D geospatial ecosystem to Unreal Engine
https://cesium.com/platform/cesium-for-unreal/
Apache License 2.0
902 stars 287 forks source link

Support `KHR_texture_transform` in property texture properties #1367

Closed j9liu closed 5 months ago

j9liu commented 5 months ago

Depends on https://github.com/CesiumGS/cesium-native/pull/822, so merge that first.

Similar to #1360 . Use https://github.com/CesiumGS/cesium/tree/main/Specs/Data/Models/glTF-2.0/PropertyTextureWithTextureTransform/glTF for this one.

Picking

Styling

Bonus Changes

1330 unfortunately made things complicated for the sample models used, because the base color texture and the features / metadata texture used are the same. I feel like this isn't a robust fix, but what I've done as a band-aid for the release:

@kring I know you suggested the approach of duplicating textures in the glTF itself, but I'm hesitant to modify the glTF images itself? (maybe unjustifiably so). But let me know if what I've done is atrocious.

kring commented 5 months ago

@j9liu when you've addressed the minor comments here and in https://github.com/CesiumGS/cesium-native/pull/822, please go ahead and merge them yourself. That way I won't need to wait for CI before I can start the release process at the end of your day today.

j9liu commented 5 months ago

Thanks @kring for the review! Merging with your approval.