search

CesiumGS / cesium-unreal

Bringing the 3D geospatial ecosystem to Unreal Engine
https://cesium.com/platform/cesium-for-unreal/
Apache License 2.0
885 stars 286 forks source link

Update `CesiumRuntime.Build.cs` for Cesium Native changes #1401

Closed j9liu closed 2 months ago

j9liu commented 2 months ago
csciguy8 commented 2 months ago

Look like good changes to update cesium-native.

Seeing this weird CI error across all iOS versions... CMake Error at cesium-native/CMakeLists.txt:210 (install): install TARGETS given no FRAMEWORK DESTINATION for static library FRAMEWORK target "ktx".

Not obvious why this is occurring. Looking into it... (unless you beat me to it)

j9liu commented 2 months ago

Earlier in the iOS CI logs, I see this warning as well. Not sure if it's related:

CMake Warning at cesium-native/extern/KTX-Software/cmake/version.cmake:151 (message): Error retrieving version from GIT tag. Falling back to 0.0.0-noversion Call Stack (most recent call first): cesium-native/extern/KTX-Software/CMakeLists.txt:13 (include)

csciguy8 commented 2 months ago

I think I have a fix for the iOS cmake errors.

Needed a cesium-native change, so I committed that update.

This PR now depends on cesium-native PR 869

j9liu commented 2 months ago

@csciguy8 I was making some changes to sync with the new cesium-native changes before this was merged. I'm going to cancel your CI build and push them to main directly.

csciguy8 commented 2 months ago

Whoops! Go for it.