search

CesiumGS / cesium-unreal

Bringing the 3D geospatial ecosystem to Unreal Engine
https://cesium.com/platform/cesium-for-unreal/
Apache License 2.0
921 stars 295 forks source link

remove the baseColorFactor alpha check when selecting base material #1445

Closed EvenZHAnglll closed 3 months ago

EvenZHAnglll commented 4 months ago

fix https://github.com/CesiumGS/cesium-unreal/issues/1160

j9liu commented 4 months ago

Thanks for the pull request @EvenZHAnglll!

Could you please sign our Contributor License Agreement? Once it's signed, we'll be able to take a look at your changes. Thank you!

EvenZHAnglll commented 4 months ago

Thanks for the pull request @EvenZHAnglll!

Could you please sign our Contributor License Agreement? Once it's signed, we'll be able to take a look at your changes. Thank you!

Sure. I've signed the CLA.

j9liu commented 4 months ago

Looks good to me @EvenZHAnglll ! Can you do one more thing: add a note about this to CHANGES.md?

You can copy paste this at the top, if you'd like:

? - ?

Fixes 🔧

  • Removed unnecessary alpha check when selecting translucent base materials.
EvenZHAnglll commented 4 months ago

Looks good to me @EvenZHAnglll ! Can you do one more thing: add a note about this to CHANGES.md?

You can copy paste this at the top, if you'd like:

? - ? Fixes 🔧

  • Removed unnecessary alpha check when selecting translucent base materials.

OK, it's added.

j9liu commented 3 months ago

Sorry for the wait on this @EvenZHAnglll ! Merging now, thank you for the contribution :pray: