search

CesiumGS / cesium-unreal

Bringing the 3D geospatial ecosystem to Unreal Engine
https://cesium.com/platform/cesium-for-unreal/
Apache License 2.0
879 stars 285 forks source link

UE 5.4 - Add include for UStaticMesh and use glm::mat4_cast instead of glm::toMat4 #1453

Closed therpgmaster closed 1 week ago

therpgmaster commented 3 weeks ago

We ran into issues building the plugin with UE 5.4.2, in release configuration. StaticMesh.h is required for the declaration of the UStaticMesh class. Additionally, the toMat4 conversion function does not work here, however we can use mat4_cast instead, without changing dependencies.

kring commented 2 weeks ago

Thanks for the PR @therpgmaster! Before we can review and merge it, can I please bug you to sign the Contributor License Agreement: https://github.com/CesiumGS/cesium/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla

therpgmaster commented 2 weeks ago

@kring

Thanks for the PR @therpgmaster! Before we can review and merge it, can I please bug you to sign the Contributor License Agreement: https://github.com/CesiumGS/cesium/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla

No problem, done.

azrogers commented 1 week ago

Thanks @therpgmaster!