Fix crash caused by CesiumSunSky when no viewport is activated in the Editor.

CesiumGS / cesium-unreal

Bringing the 3D geospatial ecosystem to Unreal Engine

https://cesium.com/platform/cesium-for-unreal/

Apache License 2.0

879 stars 285 forks source link

Closed yuziqii closed 2 weeks ago

yuziqii commented 2 weeks ago

Check pViewport validity before dereferencing it.

j9liu commented 2 weeks ago

Thanks @yuziqii ! Just two things:

Before we can review and merge your PR, could you sign the Contributor License Agreement here?
Could you add a note to CHANGES.md about this? You can copy paste this text at the top of the document, if you'd like:

? - ?

##### Fixes :wrench:

- Fixed a crash caused by `CesiumSunSky` when no viewport is activated in the Editor.

yuziqii commented 2 weeks ago

Sure, I've already signed the agreement and made the update in CHANGES.md.

j9liu commented 2 weeks ago

Thank you @yuziqii ! :smile: Looks good to me, merging now