Remove node externals for build - Githubissues

CesiumGS / cesium-webpack-example

The minimal recommended setup for an application using Cesium with Webpack.

Apache License 2.0

243 stars 160 forks source link

Remove node externals for build #56

Closed jjspace closed 7 months ago

jjspace commented 7 months ago

With the release of CesiumJS v1.114 which included https://github.com/CesiumGS/cesium/pull/11773 the external node modules are no longer necessary and can be excluded from the config. This pr removes them.

Testing

This only affects the Webpack 5 version but ensure that Webpack 4 still works

clean your local project
In each webpack directory, webpack-4 and webpack-5
- run npm install
- run npm run start and check the local version works
- run npm run build and make sure there are no errors
- run npm run start:built and make sure the local built version still works

ggetz commented 7 months ago

Looks good @jjspace! I confirmed that there's no need to update the webpack 4 config, just webpack 5. Thanks!