Closed ptrgags closed 2 years ago
Beginning to test how the CZML / Entity
system holds up if we switch Model
to ModelExperimental
. I'm leaving notes as I go. Testing in Windows 10 / Chrome 103.0.5060.53
ModelVisualizer
Model.fromGltf
with ModelExperimental.fromGltf
ModelVisualizer.getBoundingSphere
3D Models
ModelExperimental |
Model |
---|---|
3D Models Coloring
Model
makes a silhouette with the entire model, but ModelExperimental
makes silhouettes for each primitive, so some of the primitives' silhouettes overlap the model. This is evident in the Aircraft model.
ModelExperimentalDrawCommand
ModelExperimental |
Model |
---|---|
Bloom (uses entity model) - no difference Clamp to 3D Model - no difference
Clamp to 3D Tiles
id
in ModelExperimental
.Custom Per-Feature Post Process
Depth of Field (uses entity model) - no difference Distance Display Conditions - no difference Lighting (uses entity model) - no difference
Per-Feature Post Processing
Physically-Based Materials
Post Processing (uses entity model) - no difference Projection (uses entity model) - no difference
Shadows
Model
results in artifacts as well.Terrain Clipping Planes (uses entity model) - no difference
Time-Dynamic Wheels
Model.getNode
function to work, but this doesn't exist for ModelExperimental
, so it crashes.I went through all of the sandcastles involving these changes. They all appear to work after #10530 was merged + subsequent PRs were merged to fix the bugs. I'm closing this issue now.
While reviewing #10282, I noticed that models used in CZML and entities only use the old
Model
. (seeModelVisualizer.js
where it callsModel.fromGltf()
). This is fine for now, but when we replace the oldModel
withModelExperimental
, we need to make sure this still works.Some things to check for API parity:
ModelExperimental