CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:
https://cesium.com/cesiumjs/
Apache License 2.0
12.85k stars 3.47k forks source link

Ensure entities and CZML work with `ModelExperimental` #10285

Closed ptrgags closed 2 years ago

ptrgags commented 2 years ago

While reviewing #10282, I noticed that models used in CZML and entities only use the old Model. (see ModelVisualizer.js where it calls Model.fromGltf()). This is fine for now, but when we replace the old Model with ModelExperimental, we need to make sure this still works.

Some things to check for API parity:

j9liu commented 2 years ago

Beginning to test how the CZML / Entity system holds up if we switch Model to ModelExperimental. I'm leaving notes as I go. Testing in Windows 10 / Chrome 103.0.5060.53

ModelVisualizer

Sandcastles

3D Models

ModelExperimental Model
image image

3D Models Coloring

ModelExperimental Model
image image

Bloom (uses entity model) - no difference Clamp to 3D Model - no difference

Clamp to 3D Tiles

clamptoground

Custom Per-Feature Post Process

Depth of Field (uses entity model) - no difference Distance Display Conditions - no difference Lighting (uses entity model) - no difference

Per-Feature Post Processing

Physically-Based Materials

Post Processing (uses entity model) - no difference Projection (uses entity model) - no difference

Shadows

Terrain Clipping Planes (uses entity model) - no difference

Time-Dynamic Wheels

j9liu commented 2 years ago

I went through all of the sandcastles involving these changes. They all appear to work after #10530 was merged + subsequent PRs were merged to fix the bugs. I'm closing this issue now.