CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:
https://cesium.com/cesiumjs/
Apache License 2.0
12.93k stars 3.48k forks source link

Superfluous characters in "HTML body & CSS" tab of all Sandcastles #10917

Closed javagl closed 1 year ago

javagl commented 1 year ago

The contents of the "HTML body & CSS" tab of sandcastles starts with an unnecessary ";:

Cesium SandcastleHtml

Note that this does only happen in the deployed version of the Sandcastles, at https://sandcastle.cesium.com/index.html . It does not happen when running CesiumJS locally.

I started investigating this a bit. I'm reasonably sure that this is caused by the messed up semicolons/string quote characters in this line, which causes an output of

<script>window.CESIUM_BASE_URL = "../CesiumUnminified/";</script>";

where it should only be

<script>window.CESIUM_BASE_URL = "../CesiumUnminified/"</script>

as it can be seen in the source view:

Cesium Sandcastle HTML Characters

The combination of my lack of knowledge about the build- and deployment process as a whole and the fact that it only appears in the deployed version makes it impossible (for me, in a reasonable time frame) to confirm this, but ... I'd say that it's very likely that this is the reason. (Even if it was not the reason for the issue, this should still be fixed...)

ggetz commented 1 year ago

Fixed in #10918.