CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:
https://cesium.com/cesiumjs/
Apache License 2.0
12.81k stars 3.46k forks source link

Performance drop with points cloud and apearance issues starting from version 1.97. #11196

Open ilyaly opened 1 year ago

ilyaly commented 1 year ago

Description:

Point Cloud tilesets that were rendered without any problems in Cesium 1.96 and prior versions are rendered inappropriately and with a significant performance drops in Cesium starting from version 1.97.

Examples:

  1. Appearance in 1.95 - everything is normal:

image|671x500

Appearance in 1.97 and up to 1.103 - points are to dark and there are some weird artifacts on tiles edges. Performance drops in 10-15 seconds of viewing:

image|688x500

Appearance in 1.103 - points are bright as they should be but there are still some weird artifacts on tiles edges. Performance drops in 10-15 seconds of viewing:

image|690x408

Sandcastle example

Details:

Browser: Chrome Version 111.0.5563.146 (Official Build) (64-bit)

Operating System: Microsoft Windows 11 Pro Version10.0.22000 Build 22000

Tileset: generated with Agisoft Metashape.

Comments

Probably related to https://github.com/CesiumGS/cesium/issues/11166.

ilyaly commented 1 year ago

In case it may be helpful - tileset is generated with Draco compression.

ilyaly commented 1 year ago

Seems like Draco compression is not the source of the issues.

Here is a Sandcastle with the point cloud exported from Metashape with compression on,

and here is a Sandcastle with the point cloud exported from Metashape with compression off.

ilyaly commented 1 year ago

Looks related or even duplicating #11270

ilyaly commented 1 year ago

Attaching profile. Trace-point-cloud-no-styling.json.zip

ilyaly commented 1 year ago

I don't see any performance problems in version 1.109, looks like it has been fixed somehow.

ilyaly commented 4 months ago

Actually the issue is still valid in case the point cloud tileset has normals.

Sandcastle with the point cloud with normals.

Sandcastle with the point cloud with no normals.