Cesium after 1.96 had low performance with GLTF extension CESIUM_primitive_outline

CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:

https://cesium.com/cesiumjs/

Apache License 2.0

12.73k stars 3.45k forks source link

Cesium after 1.96 had low performance with GLTF extension CESIUM_primitive_outline #12077

Open MingFanZhu opened 2 months ago

MingFanZhu commented 2 months ago

What happened?

When load same 3DTile whitch has CESIUM_primitive_outline extension,Cesium after 1.96 shows bad performance.It seems like related to the upgrade of ModelLoader since 1.97.Chrome shows PrimitiveOutlineGenerator.updateAttribute takes too much time.Could you check if there are any issues？微信图片编辑_20240710135425

Reproduction steps

1. 2. 3. ...

Sandcastle example

No response

Environment

Browser:chrome 126.0.6478.127 CesiumJS Version:1.97 Operating System:windows 10

ggetz commented 2 months ago

Thanks for the report @MingFanZhu. It's very possible that the refactor from 1.96 affected the performance here.

MingFanZhu commented 2 months ago

Thank you for your response. Are there any plans to address this issue?

ggetz commented 2 months ago

@MingFanZhu There are no immediate plans to prioritize this issue at the moment.

If you'd like to add more information about your use case, that may help us prioritize. If you are interesting in contributing, please let us know and we'd be happy to discuss implementation or review a PR. Thanks!

MingFanZhu commented 2 months ago

I have made code modifications regarding this issue, please review them for appropriateness. CESIUM_primitive_outline performance #12084