search

CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:
https://cesium.com/cesiumjs/
Apache License 2.0
12.91k stars 3.48k forks source link

LICENSE.md contains non-existent link to NVIDIA GameWorks Graphics Samples project #12123

Open geekythoughts opened 2 months ago

geekythoughts commented 2 months ago

What happened?

The project's LICENSE.md file references the "NVIDIA GameWorks Graphics Samples" under third party code however, the referenced GitHub project no longer exists: https://github.com/NVIDIAGameWorks/GraphicsSamples

Given the referenced NVIDIA GameWorks graphics sample project no longer exists, the reference to this project and license should get removed. The existence of this license may raise concerns from users, developers, and organizations for using Cesium.

There's also a reference to the NVIDIA GameWorkds Graphics Samples project is found in in the following (relative) source: packages/engine/Source/Shaders/FXAA3_11.glsl#L3 however, the license content differs than the license contents listed within LICENSE.md.

Is this NVIDIA samples project still used or perhaps moved to another repo and can this discrepancy get resolved?

Reproduction steps

  1. N/A - docuentation/license issue

  3. ...

Sandcastle example

No response

Environment

N/A - this is a documentation/licensing issue

ggetz commented 2 months ago

Thanks for the report @geekythoughts. We'll look into how much, if any, came from that project and be sure to update the licensing accordingly.