CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:
https://cesium.com/cesiumjs/
Apache License 2.0
13.02k stars 3.51k forks source link

feat: Introduce `SampledProperty` new function `getSample` #12253

Closed s3xysteak closed 5 days ago

s3xysteak commented 1 month ago

Description

The PR add a new function getSample to SampledProperty, which provides a feature to get the time of samples by index.

Issue number and link

Closes #12245.

Testing plan

Technically speaking, it only performs simple operations on arrays. I add a simple unit test to check if it works well.

Author checklist

github-actions[bot] commented 1 month ago

Thank you for the pull request, @s3xysteak!

:white_check_mark: We can confirm we have a CLA on file for you.

ggetz commented 1 month ago

Thanks for the PR @s3xysteak!

@lukemckinstry Could you please review?

ggetz commented 1 week ago

@s3xysteak I noticed that there hasn't been any updates on this recently. Are you still planning on moving forward with this PR in the near future? If not, I'll close this for now to keep things tidy.

ggetz commented 1 week ago

@s3xysteak Please resolve any conflicts tithe the main branch, and ensure you're changes are listed in CHANGES.md under the next release: 1.124.

ggetz commented 5 days ago

Looks great! Thanks @s3xysteak!