Closed jjspace closed 3 weeks ago
Thank you for the pull request, @jjspace!
:white_check_mark: We can confirm we have a CLA on file for you.
I opened https://github.com/CesiumGS/cesium/issues/12285 to discuss changing the Timeline itself which I think would've avoided this issue and may allow us to remove the linkTimelineToDataSourceClock
function in its entirety but that doesn't need to hold up this PR right before the release
CC @jfayot No action needed but thought you might be interested in this follow up. Something I missed while reviewing your PR. Odd little side effect of the weird way these classes interact with each other and the order event handlers are triggered. If you do think of a better solution than this please let us know.
Description
In https://github.com/CesiumGS/cesium/pull/12202 we moved most of the tracking logic into the
CesiumWidget
class. However this skipped the update for the timeline to zoom it to the correct time period when data sources are added, like in this sandcastleThere may be a cleaner solution here but I think this closely matches the previous behavior. Longer term I would've expected the timeline to reflect the values of the
clock
closer including the start/end times like the Animation widget does.(We also noticed the model disappears but that's a separate issue https://github.com/CesiumGS/cesium/issues/12282)
Issue number and link
No issue
Testing plan
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change