Closed ggetz closed 2 weeks ago
Thank you for the pull request, @ggetz!
:white_check_mark: We can confirm we have a CLA on file for you.
@jjspace This is ready for review!
I was also seeing some extra spec failures on this branch locally that aren't happening in main. Not sure if it's directly related to this change or not
Good catch @jjspace, I must have forgotten to run all tests without --webgl-stub
locally. These failures are expected. Fixed with some minor cleanup.
Description
While the extensions needed for dynamic environment lighting are available in most systems, we were seeing downstream testing difficulties when using a WebGL stub that didn't support the required WebGL extensions.
This change:
DynamicEnvironmentMapManager.isDynamicUpdateSupported
to allow for checking.DynamicEnvironmentMapManager.DEFAULT_SPHERICAL_HARMONIC_COEFFICIENTS
for convenience.Diffuse lighting when dynamic updates are disabled or not supported
Before: No diffuse light if dynamic updates were disabled
Issue number and link
N/A
Testing plan
--webgl-stub
)enabled
tofalse
, as in this SandcastleAuthor checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change