CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:
https://cesium.com/cesiumjs/
Apache License 2.0
12.91k stars 3.48k forks source link

3D Tiles Inspector #4846

Closed pjcozzi closed 7 years ago

pjcozzi commented 7 years ago

This will allow us to remove a lot of prototype and duplicate code in Sandcastle examples, and will allow users to embed the inspector in their apps for easily debugging and profiling.

The UI design is open-ended; feel free to make it much better than the collection of buttons in the Sandcastle examples.

Phase one is to just replace the debugging functionality already in the Sandcastle examples; we can do more pull requests as new features are needed. Do not worry about the current style options in the Sandcastle examples for the first pull request.


For @austinEng when ready.

austinEng commented 7 years ago

Show stats and Show pick stats. These could be shown in the inspector UI instead of the console.

Does this mean to entirely remove console logging or to just show the information in the inspector as well? Logging of the stats is implemented within Cesium3DTileset and removing it would involve disabling the debug flags for statistics. We can still pull the statistics from the tileset as you said, but would doing so without debug flags be inconsistent?

pjcozzi commented 7 years ago

I think we can just remove debugShowStatistics and debugShowPickStatistics, expose a @private getter for _statistics, and then basically move the showStats logic to the inspector.

See how it feels.