search

CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:
https://cesium.com/cesiumjs/
Apache License 2.0
12.4k stars 3.38k forks source link

Lens Flare artifact #5932

Open bagnell opened 6 years ago

bagnell commented 6 years ago

From the post-processing-1.0 branch, open the Lens Flare Sandcastle example and click View from Everest. You'll see this:

image

Any ideas how to fix this @byumjin?

CC #5615

byumjin commented 6 years ago

Sorry, there is no way to fix it Because, it uses the scene image for its ghost effects, not the HDR scene image (only bright part). Thus, only space scene could show the appropriate result :(

pjcozzi commented 6 years ago

Thanks @byumjin! We plan to implement HDR - will that fix this? Or will we need to do additional work once HDR is implemented?

byumjin commented 6 years ago

it needs additional work creating a shader extracting bright color part from HDR instead of just using scene image.

pjcozzi commented 6 years ago

Gotcha, thanks @byumjin!

@bagnell up to you if you want to just keep this as a known issue or add the disable workaround.

bagnell commented 6 years ago

A temporary workaround was added in 500660d1a26c20f290a42cd44a417ea0c4458754. The lens flare is disabled when not in space.